User info desktop/#81 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
โฆin user-handler.mock.ts
|
๐storybook: https://65ccb85d5afe55a024495bc0-pitprhcbcy.chromatic.com/ |
gahyuun
reviewed
Apr 19, 2024
| @@ -33,12 +33,12 @@ export const userHandlers = [ | |||
| }), | |||
| http.get<never, never, UserInfoResponse | ErrorResponseData>(`${API_PATH.user}`, async ({ request }) => { | |||
| const accessToken = request.headers.get('Authorization')?.replace('Bearer ', ''); | |||
| if (!accessToken) { | |||
| if (accessToken === 'undefined' || !accessToken) { | |||
There was a problem hiding this comment.
accessToken ์ด "undefined"์ธ ๊ฒฝ์ฐ์ ๋ํด ์ค๋ช ํด์ฃผ์ค ์ ์๋์??
There was a problem hiding this comment.
headers: {
Authorization: `Bearer ${cookies().get('accessToken')?.value}`,
},
- ์์ ๊ฐ์ด ํค๋๋ฅผ ์ถ๊ฐํ๋ค ๋ณด๋, accessToken์ด ์๋ ๊ฒฝ์ฐ์ 'undefined'๊ฐ ๋ฆฌํฐ๋ด ๊ฐ์ผ๋ก ๋ค์ด๊ฐ๋ ๊ฒฝ์ฐ๋ฅผ ํ์ธํ์๊ณ , ์ด์ ๋ฐ๋ผ ์์ ํ์์ต๋๋ค.
gahyuun
previously approved these changes
Apr 19, 2024
yougyung
previously approved these changes
Apr 19, 2024
There was a problem hiding this comment.
๋๋ฉ์ธ์ปดํฌ๋ํธ์ ์์น์ํค์ ์ด์ ๊ฐ ๊ถ๊ธํด์ !
There was a problem hiding this comment.
- ๊ทผ์ฒ์ ์์น์ํค๊ณ ์ถ์ ์๋๊ฐ ์์๋๋ฐ, ๋ง์ํ์ ๋๋ก ์ด๋ฌ๋ฉด ๋๋ฉ์ธ ์ปดํฌ๋ํธ๋ก ์คํดํ ์ ์์ผ๋, ๊ฐ์ ํ์ผ์ ์์นํ๋๋ก ์์ ํ์ต๋๋ค. ๊ณ ๋ง์ต๋๋ค
|
๐storybook: https://65ccb85d5afe55a024495bc0-xzbtpiznfa.chromatic.com/ |
gahyuun
approved these changes
Apr 20, 2024
yougyung
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ์์ ๋ด์ฉ
๐ค ๊ณ ๋ฏผ ํ๋ ๋ถ๋ถ